Code review (googleanalytics)

Coder found 1 projects, 2 files
Coder provides helpful hints without false positives, but offers no guarantee for creating good code. You are the final arbitrar. If in doubt, read the Drupal documentation (see review links below and api.drupal.org).
Use the Selection Form to select options for this code review, or change the Default Settings and use the Default tab above.
sites/default/modules/google_analytics/googleanalytics.module

googleanalytics.module

  • severity: normalLine 73: do not use mixed case (camelCase), use lower case and _
        if ($trackOutgoing = variable_get('googleanalytics_trackoutgoing', 1)) {
  • severity: normalLine 74: do not use mixed case (camelCase), use lower case and _
          $link_settings['trackOutgoing'] = $trackOutgoing;
  • severity: normalLine 76: do not use mixed case (camelCase), use lower case and _
        if ($trackMailto = variable_get('googleanalytics_trackmailto', 1)) {
  • severity: normalLine 77: do not use mixed case (camelCase), use lower case and _
          $link_settings['trackMailto'] = $trackMailto;
  • severity: normalLine 79: do not use mixed case (camelCase), use lower case and _
        if (($trackDownload = variable_get('googleanalytics_trackfiles', 1)) && ($trackfiles_extensions = variable_get('googleanalytics_trackfiles_extensions', GA_TRACKFILES_EXTENSIONS))) {
  • severity: normalLine 80: do not use mixed case (camelCase), use lower case and _
          $link_settings['trackDownload'] = $trackDownload;
  • severity: normalLine 111: else statements should begin on a new line
            } else {