Home

Code review (filter)

  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
  • : Function ereg() is deprecated in /opt/home/drupalcode/public_html/includes/file.inc on line 649.
Coder found 1 projects, 1 files
Coder provides helpful hints without false positives, but offers no guarantee for creating good code. You are the final arbitrar. If in doubt, read the Drupal documentation (see review links below and api.drupal.org).
Use the Selection Form to select options for this code review, or change the Default Settings and use the Default tab above.
modules/filter/filter.module

filter.module

  • severity: normalLine 176: string concatenation should be formatted without a space separating the operators (dot .) and a quote
                    'strong' => array( t('Strong'), '<strong>'. t('Strong'). '</strong>'),
  • severity: normalLine 176: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
                    'strong' => array( t('Strong'), '<strong>'. t('Strong'). '</strong>'),
  • severity: normalLine 318: missing space after comma
        $form[$format->name]['roles'] = array('#value' => $default ? t('All roles may use default format') : ($roles ? implode(', ',$roles) : t('No roles may use this format')));
  • severity: normalLine 648: string concatenation should be formatted without a space separating the operators (dot .) and a quote
          $query .= ' WHERE '. implode(' OR ', $where) . ' OR format = %d';
  • severity: normalLine 945: string concatenation should be formatted without a space separating the operators (dot .) and a quote
            $tips .= '<li'. ($long ? ' id="filter-'. str_replace("/", "-", $tip['id']) .'">' : '>') . $tip['tip'] . '</li>';
  • severity: normalLine 1149: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      return $match[1] . '<a href="'. $match[2] .'" title="'. $match[2] .'">'. $caption .'</a>'. $match[5];
  • severity: normalLine 1159: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      return $match[1] . '<a href="http://'. $match[2] .'" title="'. $match[2] .'">'. $caption .'</a>'. $match[3];