Home

Code review (book)

Coder found 1 projects, 2 files
Coder provides helpful hints without false positives, but offers no guarantee for creating good code. You are the final arbitrar. If in doubt, read the Drupal documentation (see review links below and api.drupal.org).
Use the Selection Form to select options for this code review, or change the Default Settings and use the Default tab above.
modules/book/book.module

book.module

  • severity: normalLine 130: Use ANSI standard <> instead of !=
          $result = db_query(db_rewrite_sql("SELECT n.nid FROM {node} n WHERE n.nid = %d AND n.type != 'book'"), arg(1));
  • severity: normalLine 707: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      $html .= '<base href="'. $base_url .'/" />' . "\n";
  • severity: normalLine 865: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
          l(t('delete'), 'node/'. $nid .'/delete', NULL, 'destination=admin/content/book'. (arg(3) == 'orphan' ? '/orphan' : '') . ($pid != $nid ? '/'.$pid : ''))