Home

Code review (bluemarine)

Coder found 1 projects, 6 files, 14 normal warnings
Coder provides helpful hints without false positives, but offers no guarantee for creating good code. You are the final arbitrar. If in doubt, read the Drupal documentation (see review links below and api.drupal.org).
Use the Selection Form to select options for this code review, or change the Default Settings and use the Default tab above.
themes/bluemarine/page.tpl.php

page.tpl.php

  • severity: normalInclude the CVS keyword $Id$ in each file
  • severity: normalLine 17: The control statement should be on a separate line from the control conditional
          <?php if ($logo) { ?><a href="<?php print $base_path ?>" title="<?php print t('Home') ?>"><img src="<?php print $logo ?>" alt="<?php print t('Home') ?>" /></a><?php } ?>
  • severity: normalLine 18: The control statement should be on a separate line from the control conditional
          <?php if ($site_name) { ?><h1 class='site-name'><a href="<?php print $base_path ?>" title="<?php print t('Home') ?>"><?php print $site_name ?></a></h1><?php } ?>
  • severity: normalLine 19: The control statement should be on a separate line from the control conditional
          <?php if ($site_slogan) { ?><div class='site-slogan'><?php print $site_slogan ?></div><?php } ?>
  • severity: normalLine 22: Arrays should be formatted with a space separating each element and assignment operator
          <?php if (isset($secondary_links)) { ?><?php print theme('links', $secondary_links, array('class' =>'links', 'id' => 'subnavlist')) ?><?php } ?>
  • severity: normalLine 22: The control statement should be on a separate line from the control conditional
          <?php if (isset($secondary_links)) { ?><?php print theme('links', $secondary_links, array('class' =>'links', 'id' => 'subnavlist')) ?><?php } ?>
  • severity: normalLine 23: Arrays should be formatted with a space separating each element and assignment operator
          <?php if (isset($primary_links)) { ?><?php print theme('links', $primary_links, array('class' =>'links', 'id' => 'navlist')) ?><?php } ?>
  • severity: normalLine 23: The control statement should be on a separate line from the control conditional
          <?php if (isset($primary_links)) { ?><?php print theme('links', $primary_links, array('class' =>'links', 'id' => 'navlist')) ?><?php } ?>
  • severity: normalLine 38: The control statement should be on a separate line from the control conditional
          <?php if ($mission) { ?><div id="mission"><?php print $mission ?></div><?php } ?>
themes/bluemarine/node.tpl.php

node.tpl.php

  • severity: normalLine 1: The control statement should be on a separate line from the control conditional
      <div class="node<?php if ($sticky) { print " sticky"; } ?><?php if (!$status) { print " node-unpublished"; } ?>">
  • severity: normalLine 5: The control statement should be on a separate line from the control conditional
        <?php if ($page == 0) { ?><h2 class="title"><a href="<?php print $node_url?>"><?php print $title?></a></h2><?php }; ?>
  • severity: normalLine 9: The control statement should be on a separate line from the control conditional
        <?php if ($links) { ?><div class="links">&raquo; <?php print $links?></div><?php }; ?>
themes/bluemarine/comment.tpl.php

comment.tpl.php

  • severity: normalLine 5: The control statement should be on a separate line from the control conditional
    <h3 class="title"><?php print $title; ?></h3><?php if ($new != '') { ?><span class="new"><?php print $new; ?></span><?php } ?>
themes/bluemarine/page.tpl.php

page.tpl.php

  • severity: normalInclude the CVS keyword $Id$ in each file
  • severity: normalLine 17: The control statement should be on a separate line from the control conditional
          <?php if ($logo) { ?><a href="<?php print $base_path ?>" title="<?php print t('Home') ?>"><img src="<?php print $logo ?>" alt="<?php print t('Home') ?>" /></a><?php } ?>
  • severity: normalLine 18: The control statement should be on a separate line from the control conditional
          <?php if ($site_name) { ?><h1 class='site-name'><a href="<?php print $base_path ?>" title="<?php print t('Home') ?>"><?php print $site_name ?></a></h1><?php } ?>
  • severity: normalLine 19: The control statement should be on a separate line from the control conditional
          <?php if ($site_slogan) { ?><div class='site-slogan'><?php print $site_slogan ?></div><?php } ?>
  • severity: normalLine 22: Arrays should be formatted with a space separating each element and assignment operator
          <?php if (isset($secondary_links)) { ?><?php print theme('links', $secondary_links, array('class' =>'links', 'id' => 'subnavlist')) ?><?php } ?>
  • severity: normalLine 22: The control statement should be on a separate line from the control conditional
          <?php if (isset($secondary_links)) { ?><?php print theme('links', $secondary_links, array('class' =>'links', 'id' => 'subnavlist')) ?><?php } ?>
  • severity: normalLine 23: Arrays should be formatted with a space separating each element and assignment operator
          <?php if (isset($primary_links)) { ?><?php print theme('links', $primary_links, array('class' =>'links', 'id' => 'navlist')) ?><?php } ?>
  • severity: normalLine 23: The control statement should be on a separate line from the control conditional
          <?php if (isset($primary_links)) { ?><?php print theme('links', $primary_links, array('class' =>'links', 'id' => 'navlist')) ?><?php } ?>
  • severity: normalLine 38: The control statement should be on a separate line from the control conditional
          <?php if ($mission) { ?><div id="mission"><?php print $mission ?></div><?php } ?>
themes/bluemarine/box.tpl.php

box.tpl.php

  • severity: normalLine 2: The control statement should be on a separate line from the control conditional
        <?php if ($title) { ?><h2 class="title"><?php print $title; ?></h2><?php } ?>