Home

Code review (aggregator)

Coder found 1 projects, 2 files
Coder provides helpful hints without false positives, but offers no guarantee for creating good code. You are the final arbitrar. If in doubt, read the Drupal documentation (see review links below and api.drupal.org).
Use the Selection Form to select options for this code review, or change the Default Settings and use the Default tab above.
modules/aggregator/aggregator.module

aggregator.module

  • severity: normalLine 1051: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      drupal_add_feed(url('aggregator/rss'), variable_get('site_name', 'Drupal') . ' ' . t('aggregator'));
  • severity: normalLine 1072: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      drupal_add_feed(url('aggregator/rss/'. arg(2)), variable_get('site_name', 'Drupal') . ' ' . t('aggregator - @title', array('@title' => $category->title)));
  • severity: normalLine 1211: string concatenation should be formatted without a space separating the operators (dot .) and a quote
        $url = '/categories/' . $category->cid;
  • severity: normalLine 1212: string concatenation should be formatted without a space separating the operators (dot .) and a quote
        $title = ' ' . t('in category') . ' ' . $category->title;
  • severity: normalLine 1235: string concatenation should be formatted without a space separating the operators (dot .) and a quote
        $items .= format_rss_item($item->ftitle . ': ' . $item->title, $item->link, $item->description, array('pubDate' => date('r', $item->timestamp)));
  • severity: normalLine 1240: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      $output .= format_rss_channel(variable_get('site_name', 'Drupal') . ' ' . t('aggregator'), url('aggregator' . $url, NULL, NULL, TRUE), variable_get('site_name', 'Drupal') . ' - ' . t('aggregated feeds') . $title, $items, 'en');
  • severity: normalLine 1331: string concatenation should be formatted without a space separating the operators (dot .) and a quote
      $output .= '<div class="feed-updated"><em>'. t('Updated:') . "</em> $updated</div>";
  • severity: normalLine 1383: string concatenation should be formatted without a space separating the operators (dot .) and a quote
        $source = l($item->ftitle, "aggregator/sources/$item->fid", array('class' => 'feed-item-source')) . ' -';